search

devongovett / exif-reader

A small EXIF image metadata reader
MIT License
145 stars 22 forks source link

Exif from PNGs with eXIf chunk #21

Closed paxvista closed 1 year ago

lovell commented 1 year ago

Hi Bob, thank you for the PR, this should fix https://github.com/devongovett/exif-reader/issues/19

Did you see a possible alternative approach from @rexxars in commit https://github.com/sanity-io/exif-reader/commit/6ee2ee2f243cd6365ff4235a63797615a983fae1 ? If nothing else it might be good to include the test case here also.

paxvista commented 1 year ago

The approach from @rexxars is definitely more elegant, but creates a new buffer, which was something I was trying to avoid. Are you suggesting I include his test in my pull request?

squaredx commented 1 year ago

Hi all! Is there any status update on when this will be merged into main?

lovell commented 1 year ago

Sure, there's been no other feedback, let's merge.

squaredx commented 1 year ago

@lovell thank you so much! 🙌

ToPeas commented 1 year ago

how long will the publish new release? thanks. i really need this feature that parse png exif.

lovell commented 1 year ago

v1.1.0 now available via npm