search

devongovett / protobuf-jsonschema

Compiles Protobuf IDL to JSON Schema
119 stars 37 forks source link

Add a flag to specify 'additionalProperties' value on objects' schemas #1

Open pgirolami opened 7 years ago

pgirolami commented 7 years ago

The JSON-Schema definition allows for a additionalProperties boolean field to be added to each object definition. It defaults to true but, when false, the validator using the schemas will complain about extraneous fields.

My project currently needs this so I've tried to update the code to allow this. At the moment, I've added a flag that will apply to all protobuf messages.

If this PR is ok for you, could you issue a release of the package on the NPM repo ?

Thanks

pgirolami commented 7 years ago

Latest commit should address your point. Let me know if you want me to fix anything else.

pgirolami commented 7 years ago

Hi @devongovett , do you have time for a review of my updated PR ?

gfalcone commented 3 years ago

Hello @devongovett, I am taking over this PR. Do you need any additional changes from us to merge this PR ?