devopshobbies / boundary-vault-stack

Deploy Self-Hosted HCP Vault and Boundary using End-To-End Automation (Terraform, Ansible, Bash, and many more)
MIT License
14 stars 14 forks source link

Dev/version1 #66

Closed abolfazl8131 closed 1 month ago

abolfazl8131 commented 1 month ago

I tried to automate the vagrant and virtual box installation by adding a simple script in the scripts folder and triggering it at the start.sh

Shayan-Ghani commented 1 month ago

plz provide a description for your pr following semantic versioning, link the issue you're trying to solve

abolfazl8131 commented 1 month ago

Certainly, there is no issue i tried to solve. I've just added a simple script for some automation as I added in the description

On Wed, 16 Oct 2024 at 13:52, Shayan Ghani @.***> wrote:

plz provide a description for your pr following semantic versioning, link the issue you're trying to solve

— Reply to this email directly, view it on GitHub https://github.com/devopshobbies/boundary-vault-stack/pull/66#issuecomment-2416377607, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS7FPEMULLSPVXTRDAXF4KLZ3Y46VAVCNFSM6AAAAABQAX6GVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJWGM3TONRQG4 . You are receiving this because you authored the thread.Message ID: @.***>

Shayan-Ghani commented 1 month ago

Alright, LGTM but next time start your pr description in the following way:

fix Vagrant and virtualbox installation