search

devpunks / snuggsi

snuggsi ツ - Easy Custom Elements in ~1kB
https://snuggsi.com
MIT License
398 stars 17 forks source link

Issue/20 fix js standard code style issues #124

Closed snuggs closed 7 years ago

snuggs commented 7 years ago

Features

  1. Introduces test coverage run to bin/crank via bin/cover after compilation.
  2. Introduces bin/lint script.
  3. Runs bin/lint as an addendum to bin/cover

Related

20. #101

Description

@pachonk @tmornini tried to AWK but had the following issues (See attached image below) :

  1. Could not print a prefix on same line.
  2. Got some funky "Too many spaces at end of line error".

Above my pay grade. :thinking: Any help would be appreciated so I can finish issue #20

Not sure where this should go but introduced into bin/crank via bin/coverand also made as addendum to bin/cover @cpscott1 you wanted some JS chops. Be careful what you ask for from me hehe. You and I are on this one homie.

Links

capture d ecran 2017-07-23 a 22 39 51

capture d ecran 2017-07-23 a 23 00 35

snuggs commented 7 years ago

@pachonk updated as per your request https://github.com/devpunks/snuggsi/pull/124/commits/ff22d4554d9b1767c058b93e610bd2981738abe68. was having some funky whitespace issue prefixing number count. But was able to use something called xargs to trim that up? Seemed like the easiest solution from that sed stuff

I have no clue what i'm doing or talking about but it's working. I feel like i'm driving a race car blind in an empty parking lot.

capture d ecran 2017-07-24 a 09 21 37 capture d ecran 2017-07-24 a 09 21 26

snuggs commented 7 years ago

@pachonk everything up to snuff on my end. Removing the WIP. Please review so can merge. /cc @brandondees