Closed snuggs closed 7 years ago
@snuggs where's the actual component?
DAMMIT MAN I'm trying to troll @pachonk on https://github.com/emerald-rubies/greenhouse/issues/5
And this guy is on it like white on rice @brandondees . HEHE :trollface:
Please squash before merging :tongue:
I don't really agree with squashing unless it's a big signal to noise problem (i.e. 20 commits of "dangit what's going on?" from debugging or whatever). the full history usually has meaningful info in it and destroying that info should serve a specific purpose IMHO.
@aruprakshit @pachonk @brandondees
@snuggs You actually code in the chrome dev console full time? The 1 time I tried using it, it made every chrome console open take FOREVER.
@pachonk @brandondees @tmornini not bad render times. ;-)
@pachonk extrapolated JS into it's own lib as it was starting to outweigh the HTML.
https://github.com/devpunks/snuggsi/pull/79/commits/00596596df8e6324f90cb27a3378eb2fd51bdbcc
@brandondees @pachonk
Ok let's merge this. Signal to noise ready. :-)
@brandondees i know you like JSFiddles but this is getting a tad awkward. The "source" of the elements is being kept on JS Fiddle. As makes no sense to not keep the source with the example...which is on JSFiddle. I dunno... Just feels like for the gain the users get in having a JSFiddle we lose in risk of not keeping code. Why would we not keep code you ask? I've already been doing a dance whenever an example needs to update. Takes 3 places to update things now. :-/
I really like codepen.
I thought we'd have come up with some automated way of getting those updated from the git repo contents by now, tbh @snuggs .... I am fine with the idea of not featuring the interactive embeds, it's just a nice bit of icing on the cake for potential adopters looking at the docs. Seeing the code next to the working example is much more important than being able to tinker with it without opening devtools, so just showing a <pre>
with the code alongside the live usage is still fine in my book.
Another thought is that snuggsi should be able to power components that provide comparable, or better, UX without relying on the 3rd party.
Multiple choice element