search

dexcz / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

LibYUV should build without libjeg #346

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Libjpeg is only used in tools and tests. Right now libyuv can be built without 
libjpeg by removing the section in libyuv.gyp that references libjpeg. Maybe we 
could use a GYP_DEFINE to achieve the same result.

Original issue reported on code.google.com by t...@okcupid.com on 23 Jul 2014 at 12:32

GoogleCodeExporter commented 9 years ago 
The primary goal of libyuv is webcam support for webrtc.
MJPEG is a popular format for USB HD webcams - e.g. Logitech C920.
A secondary part of that webcam support is special effects and jpeg files can 
be used as a resource.

It does make sense to be able to build without JPEG, though.
The code is somewhat isolated into its own files.

Original comment by fbarch...@google.com on 23 Jul 2014 at 9:55

GoogleCodeExporter commented 9 years ago 
This is what I have in mind:

set GYP_DEFINES="target_arch=ia32 LIBYUV_DISABLE_JPEG=1"
call python gyp_libyuv -fninja -G msvs_version=2010 libyuv_test.gyp
ninja -C out\Release
ninja -C out\Debug

https://webrtc-codereview.appspot.com/21019004/

Original comment by fbarch...@google.com on 25 Jul 2014 at 9:22

GoogleCodeExporter commented 9 years ago 
That seems great. This allows to disable exactly the part we've been
commenting out...

Original comment by t...@okcupid.com on 26 Jul 2014 at 3:11

GoogleCodeExporter commented 9 years ago 
r1038 has the disable, but switched it to lower case

set GYP_DEFINES=target_arch=ia32 libyuv_disable_jpeg=1
python gyp_libyuv -fninja -G msvs_version=2010 libyuv_test.gyp
ninja -C out\Debug
libyuv_unittest --gtest_filter=*libyuvTest.HaveJPEG
[ RUN      ] libyuvTest.HaveJPEG
JPEG disabled
.[       OK ] libyuvTest.HaveJPEG (0 ms)

Original comment by fbarch...@google.com on 28 Jul 2014 at 9:54