search

dfaker / WebmGenerator

UI and Automation to cut, filter and join high quality webms, mp4s or gifs.
Mozilla Public License 2.0
524 stars 33 forks source link

If you load a subs file for a cut, but there aren't subs shown during your cut, the webm won't encode #49

Closed LolicoreExpress closed 3 years ago

LolicoreExpress commented 3 years ago

Title basically. If you load a subtitle file on a cut during which no subtitles lines appear, it seems that this prevents the cut from encoding.

dfaker commented 3 years ago

I'm seeing it correctly generate an empty file which encodes happily, at least with .srt inputs.

LolicoreExpress commented 3 years ago

Alright, I can reproduce, Here's more info.

I load up a movie and make one subclip during which there is no dialogue, so no subtitle lines appear. Capture d’écran 2021-11-16 181616

I then apply the subtitle filter and add the .srt subtitle file for the movie. Capture d’écran 2021-11-16 181638

And try to encode that into a 4MB VP8 Webm. That's where it fails and gets stuck at "50% encoding". Capture d’écran 2021-11-16 181531 Capture d’écran 2021-11-16 182333

I know it's kinda stupid anyway since there's really no reason to load a subtitle file on a cut which has no lines of dialogue... but yeah.

dfaker commented 3 years ago

Huh, that does complain if it's empty. Okay, I'll add a dummy line if none have been output.

BarryLyndon1975REMASTERED1080pBluRayx265-RARBG_2

LolicoreExpress commented 3 years ago

Great :) Thanks.