dfinity / eslint-config-oisy-wallet

Shared ESLint configurations from the Oisy Wallet team

Apache License 2.0

2 stars 0 forks source link

feat: Add rules to enforce arrow functions #33

Closed AntonioVentilii closed 1 week ago

AntonioVentilii commented 1 week ago

Note

This is a duplicate of PR #30 , because I changed my account.

Motivation

To further help with enforcing the arrow functions we add two rules and one plugin. This is one of the most suggested combination I found online:

prefer-arrow-callback: this will enforce arrow functions when given as callback to other statements;
func-style: the default settings of this rule forces to avoid using declaration statements for functions, for example function foo() {...}
prefer-arrow plugin: with the configs set by us, the plugin will generally make notice of the usage of function.

Changes

Installed plugin prefer-arrow.
Include rules in index file.
Fix issues raised.

Tests

The rules raised some new issues on this repo and we fixed them.