ic-pos upgrade - Githubissues

dfinity / examples

Example applications, microservices, and code samples for the Internet Computer

https://dfinity.org

Apache License 2.0

547 stars 394 forks source link

ic-pos upgrade #1053

Closed kristoferlund closed 2 days ago

kristoferlund commented 1 week ago

[0.4.0] - 2024-11-25

Changed

Major front-end overhaul, upgrading many libraries and components.
- Removed recoil for state management, now using Tanstack Router and Tanstack Query.
- Removed old axios based fetching, replacing with Tanstack Query.
- Replacing custom actor and session implementations with ic-use-actor and ic-use-internet-identity
- Upgraded Vite to new version.
- Upgraded eslint rules and version
- Cleaned up and refactored project setup, routes, and components.
- Upgrading to newer versions of the icrc canisters.

Fixed

User sessions now survive page reloads.

mbjorkqvist commented 4 days ago

Thanks a lot for the refresh, @kristoferlund ! I was wondering earlier why only the CLA check ruleset ran on my PR (and on this one), and it seems that one reason is that there is no workflow defined that would build the example and potentially run some tests, e.g., this one for the motoko vetKD example. If you'd be able to add that (possibly in a follow-up PR) that would be very helpful in making the example more robust, and e.g., making sure that version bumps of dependencies don't break it.

kristoferlund commented 4 days ago

@mbjorkqvist

Yup, will make a follow up PR.

kristoferlund commented 4 days ago

Great comments @letmejustputthishere! I fixed them all I believe.

kristoferlund commented 2 days ago

@letmejustputthishere @mbjorkqvist I think this needs an approval so that it can be merged.

letmejustputthishere commented 2 days ago

i left my review but still cant merge :(