Open dbrennand opened 5 months ago
@dbrennand Thanks for using the Excel module.
My guess is the logic when using -StartRow
does not pass thru the checks. Highly possible. That is early organic code.
No ETA on this.
I did not dig enough deep but inserting expression if ($StartRow -eq $EndRow) {$rows = 0}
after line 182 would resolve the issue and would give some hints to further exploration.
Thanks @scriptingstudio for checking that. I'll put this on the list. Need to see if there are tests, doubt it.
@scriptingstudio @dfinke - Pushed a fix for this in https://github.com/dfinke/ImportExcel/compare/master...dbrennand:ImportExcel:fix/%231587
With this change the expected warning is now showing:
Import-Excel -Path "Issue.xlsx" -WorksheetName "Sheet1" -StartRow 3
WARNING: Worksheet 'Sheet1' in workbook 'Issue.xlsx' contains no data in the rows after top row '3'
Previous behaviour is also preserved:
Import-Excel -Path "Issue.xlsx" -WorksheetName "Sheet1 (2)"
WARNING: Worksheet 'Sheet1 (2)' in workbook 'Issue.xlsx' contains no data in the rows after top row '1'
Thanks @dbrennand! I just created a branch to take a look. Were you able to take a look at the tests to see if there were any that tested this code?
Thanks @dbrennand! I just created a branch to take a look. Were you able to take a look at the tests to see if there were any that tested this code?
There are a couple of tests which already include -StartRow
- I will add the problematic workbook and include a new test for this.
It needs additional tests.
Hey @dfinke
Hope you're keeping well π
I've noticed some odd behaviour using
Import-Excel ... -StartRow 3
with an Excel spreadsheet which has the following layout:Sheet1
There are no rows containing data after the table headers however, when I import this spreadsheet it produces the following output:
Sheet1 (2)
This is working as expected and the warning is shown:
I think this issue is related to there being some data above the
StartRow 3
and the logic in thiselse
statement of theImport-Excel
cmdlet doesn't account for this case?This issue occurs on the latest module version: