dfki-ric / ugv_nav4d

A 4D (X,Y,Z, Theta) Planner for unmaned ground vehicles (UGVs).
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Build system depends on `Rock` #6

Open soraxas opened 2 months ago

soraxas commented 2 months ago

It seems the build system depends on rock, a build system macro developed by dfki.de:

https://github.com/dfki-ric/ugv_nav4d/blob/86650761370d2ed10e6fc49aa6ff797c18182a13/CMakeLists.txt#L28-L31

However, its not part of the install target in the source_dependencies scripts.

The Readme file contains the following text:

Compiling inside a ROCK environment
See the manifest.xml for an up to date list of dependencies.

Buidling inside ROCK works as usual. The package can be found in the backbone package set: https://git.hb.dfki.de/sw-backbone/package_sets

However, the gitlab link https://git.hb.dfki.de/sw-backbone/package_sets is private and requires login?

(part of https://github.com/openjournals/joss-reviews/issues/6983)

haider8645 commented 1 month ago

We use the library as part of the ROCK robotics framework developed and used at DFKI. However, from the open source user community view, we use this CMakeLists which together with installation steps should automatically setup and install all the dependencies.

haider8645 commented 1 month ago

I have removed the link to the internal https://git.hb.dfki.de/sw-backbone/package_sets because it was confusing and not relevant for the github users.

OlgerSiebinga commented 3 weeks ago

If I try to use the automatic installation, I'm still getting an error that ROCK cannot be installed:

CMake Error at /usr/share/cmake-3.22/Modules/FindPkgConfig.cmake:603 (message): A required package was not found Call Stack (most recent call first): /usr/share/cmake-3.22/Modules/FindPkgConfig.cmake:825 (_pkg_check_modules_internal) build/install/share/rock/cmake/Rock.cmake:322 (pkg_check_modules) build/install/share/rock/cmake/Rock.cmake:520 (rock_find_pkgconfig) build/install/share/rock/cmake/Rock.cmake:944 (rock_target_definition) build/install/share/rock/cmake/Rock.cmake:1042 (rock_library_common) src/CMakeLists.txt:55 (rock_library)

I followed the steps in the README file for automatic installation:

cd ugv_nav4d mkdir build && cd build cmake -DINSTALL_DEPS=ON -DCMAKE_INSTALL_PREFIX=./install .. make -j install

haider8645 commented 2 weeks ago

Which OS are you using for the build?

OlgerSiebinga commented 2 weeks ago

Ubuntu 22.04.4

haider8645 commented 2 weeks ago

Hmm, that is very strange. I followed the same steps on Ubuntu 22.04.2 LTS and it worked for me.

OlgerSiebinga commented 1 week ago

It is strange indeed. I deleted everything and started over and ran into another issue ( https://github.com/dfki-ric/ugv_nav4d/issues/9). I fixed that one, and the Rock error did not show again. But I really don't understand why it's gone now.