dfleury2 / beauty

A Simple C++ Http server/client above Boost.Beast
MIT License
188 stars 23 forks source link

Openssl enable problem in beauty/1.0.0 to beauty/1.0.3 via Conan #32

Closed barbacar closed 5 months ago

barbacar commented 5 months ago

Hello,

To use openssl in the newer versions of beauty,

"BEAUTY_ENABLE_OPENSSL" flag needs to be set.

As a default, in conanfile it is already set as "True"

but, when i try to use via conan it never sets, also if you try to set it manually it gives the error at the below,

ERROR: beauty/1.0.3: option 'openssl' doesn't exist Possible options are ['shared', 'fPIC'] CMake Error at cmake/conan.cmake:826 (message): Conan install failed='1'

When i deeply investigated i realized that "openssl" option is not exists in conan-center conan file.

https://github.com/conan-io/conan-center-index/blob/master/recipes/beauty/all/conanfile.py

So you can never enable openssl in of beauty if you use it from conan-center.

There is an incosistency between original conan file and conan-center conan file.

Best Regards,

Bonus: https://github.com/dfleury2/beauty/blob/master/CMakeLists.txt Version is still older in cmakelist

barbacar commented 5 months ago

i created this issue on here: to follow: https://github.com/conan-io/conan-center-index/issues/24363

barbacar commented 5 months ago

Issue fixed and pull request merged.