search

dfs-with-r / coach

Lineup optimization for daily fantasy sports
https://dfs-with-r.github.io/coach/
GNU General Public License v3.0
46 stars 14 forks source link

PGA functions #15

Closed sdaprix23 closed 4 years ago

sdaprix23 commented 4 years ago

Any plans on adding the PGA functions for DK/FD? Love the NFL optimizer BTW

zamorarr commented 4 years ago

hi @sdaprix23 are you still interested in this? I can add it to my list of things to start working on again

sdaprix23 commented 4 years ago

Yes please! PGA is just now getting going again

zamorarr commented 4 years ago

Hey @sdaprix23 I updated the package to include model_dk_pga() and model_fd_pga(). You'll have to re-install the package from Github to see the changes. Let me know if it everything works ok!

themultiv3rs3 commented 4 years ago

This is working great. I did notice one small issue when trying to use the write function:

Error in match.arg(sport) : 'arg' should be one of “nfl”, “mlb”, “nba”, “nhl”, “nascar”

zamorarr commented 4 years ago

Ah thanks for letting me know. I'll get that fixed tomorrow

On Wed, Jan 22, 2020, 5:09 PM algosync notifications@github.com wrote:

This is working great. I did notice one small issue when trying to use the write function:

Error in match.arg(sport) : 'arg' should be one of “nfl”, “mlb”, “nba”, “nhl”, “nascar”

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dfs-with-r/coach/issues/15?email_source=notifications&email_token=AB6A3V7PCVTNLIALE6PCIZTQ7C73HA5CNFSM4JIMAFU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJVJESA#issuecomment-577409608, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6A3V2LHI4PRBDYPKN5HO3Q7C73HANCNFSM4JIMAFUQ .

sdaprix23 commented 4 years ago

Thanks for updating this for PGA. I've been away from it for a while. There is an error when using the write-lineups as noted by algosync. I just updated to the newest available and can confirm the print error still exists.

write_lineups(lineups, "mylineups.csv", site = "draftkings", sport = "pga") Error in match.arg(sport) : 'arg' should be one of “nfl”, “mlb”, “nba”, “nhl”, “nascar”

zamorarr commented 4 years ago

Hi @sdaprix23. This should be fixed now in #21. Can you re-install the latest version of coach from github and try again? Let me know if you have any issues.

sdaprix23 commented 4 years ago

Works perfect! Thanks again for adding this.