dfsp-spirit / fsbrain

R library for structural neuroimaging. Provides high-level functions to access (read and write) and visualize surface-based brain morphometry data for individuals and groups.
Other
65 stars 13 forks source link

Error: rgl.viewpoint is depreciated #52

Closed cooperr11 closed 1 year ago

cooperr11 commented 1 year ago

Describe the bug Use of vis.() or export() functions results in error (below). 'rgl::rgl.viewpoint' is deprecated. Use 'view3d' instead.

To Reproduce Any of vis.() or export() functions reproduces this error.

Expected behavior Printing of brain maps in pop-up.

Environment:

dfsp-spirit commented 1 year ago

@cooperr11

Thanks for reporting. I can reproduce this on the latest release, 0.5.3, as reported. E.g:

library('fsbrain')
download_optional_data()
download_fsaverage(accept_freesurfer_license = TRUE)
sjd = get_optional_data_filepath("subjects_dir");
sj = 'subject1'
cm = vis.subject.morph.standard(sjd, sj, 'thickness', fwhm='10', cortex_only = T, views=NULL);
img = export(cm);

It works on the dev version though, I just tried it. I think PR48 fixed this. You can install dev like this:

install.packages(c("devtools", "knitr", "markdown", "rmarkdown", "testthat", "qpdf"));
devtools::install_github("dfsp-spirit/fsbrain");

Alternatively, if you do not want to build the doc locally and run tests, you can replace devtools with remotes, and get away with installing only minimal packages:

install.packages(c("remotes"))
remotes::install_github("dfsp-spirit/fsbrain");

Then restart R studio completely to make sure the new version actually gets used.

I will need to make a new CRAN release soon so this is fixed in the official release. Leaving this open until that's done.

cooperr11 commented 1 year ago

Hi Tim, Thanks so much! And thanks for the install instructions. I followed these and resolved the error! Although I received a new warning: _INFO [2023-06-19 09:14:23] Function shift.hemis.rglactions called, but key 'shift_hemisapart' is not present, doing nothing.

Although the code itself works fine. Thanks for the help! 👍

dfsp-spirit commented 1 year ago

It's save to ignore that message, I will remove it. It's just debug output that I left in there accidentally.

dfsp-spirit commented 1 year ago

I removed the message in 210491c, so just re-install from github to remove it if it bothers you.

dfsp-spirit commented 1 year ago

I have just released fsbrain v0.5.4 on CRAN, which is compatible with the latest rgl version and r-base 4.3.

Closing this as done.

@cooperr11 Please update to the latest official release by running install.packages("fsbrain"). Maybe wait another day to make sure the new package has been built for your OS by CRAN if you are using Windows. For Linux, you can install right away.