search

dgalbraith / chocolatey-packages

Automatic and manual Chocolatey packages
MIT License
4 stars 20 forks source link

Add OpenSSL as default installation option to be aligned with documentation #525

Closed xlammertink closed 6 months ago

xlammertink commented 9 months ago

The OpenVPN readme file claims that OpenSSL is installed in case no installation parameters are provided. However, I noticed that this is not the case according to the Chocolatey installation script. This pull request adds the OpenSSL parameter which includes OpenSSL during the installation to ensure the installation script is in line with documentation.

https://github.com/dgalbraith/chocolatey-packages/blob/3f5827f0655055c8f460fbaaab375db3c98b868a/automatic/openvpn/README.md?plain=1#L53-L55 https://github.com/dgalbraith/chocolatey-packages/blob/3f5827f0655055c8f460fbaaab375db3c98b868a/automatic/openvpn/tools/chocolateyInstall.ps1#L81-L84

dgalbraith commented 6 months ago

@xlammertink thanks for the contribution! Attention to detail appreciated - ensuring that the behavior reflected the documentation + dropping an extra space from the parameter list while you were at it.