dgodd / concourse-summary

MIT License
62 stars 12 forks source link

Toggling "ignore_groups" on breaks when giphy is on #32

Closed idoru closed 6 years ago

idoru commented 6 years ago

Steps to reproduce:

  1. Go to an excellent dashboard with some giphy action, like https://concourse-summary-crystal.cfapps.io/host/buildpacks.ci.cf-app.com?giphy=funny+cat
  2. Click on the "ignore groups" button next to the octocat in the upper right
  3. App unexpectedly 500's with mangled URI in address bar: https://concourse-summary-crystal.cfapps.io/host/buildpacks.ci.cf-app.com?giphy&ignore_groups
dgodd commented 6 years ago

@idoru This should be fixed by https://github.com/dgodd/concourse-summary/commit/6fab627cc927f26cedb4df7b2a64935a8855e9e7