ci: Add isort to linting workflow

dguest / pandamonium

Command line scripts to parse panda web api

BSD 3-Clause "New" or "Revised" License

27 stars 17 forks source link

ci: Add isort to linting workflow #54

Closed matthewfeickert closed 3 years ago

matthewfeickert commented 3 years ago

Resolves #53

Add isort to the linting workflow in CI and add isort to the lint extra.

Suggested squash and merge commit message:

* Add isort to 'lint' extra
* Add isort to linting GHA workflow
* Add pre-commit.ci status badge to README

matthewfeickert commented 3 years ago

@dguest I'd encourage enabling pre-commit.ci as well, which is great because it not only runs and enforces the pre-commit hooks in .pre-commit-config.yaml but if it finds those failed it will try to push back fixes to the PR and it will also periodically check for new releases to the hook libraries and open up automatic PRs to update them for you.

dguest commented 3 years ago

Sounds fancy. No objections here.

matthewfeickert commented 3 years ago

Sounds fancy. No objections here.

@dguest cool. :+1: I can't enable pre-commit.ci as this project is under your name, so I don't have settings control. Can you enable it?

dguest commented 3 years ago

I pushed a few buttons, I think it's enabled now.

matthewfeickert commented 3 years ago

I pushed a few buttons, I think it's enabled now.

Hm, seems not quite yet @dguest as

is still showing no run.