search

dhatim / fastexcel

Generate and read big Excel files quickly
Other
669 stars 121 forks source link

support for Worksheet.setPaperSize #217

Closed apptaro closed 1 year ago

apptaro commented 1 year ago

support for paper size. paper size enum is taken from here: https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.spreadsheet.pagesetup?view=openxml-2.8.1

apptaro commented 1 year ago

Maybe PaperSize class should be compatible with POI, let me know what you think. https://poi.apache.org/apidocs/dev/org/apache/poi/ss/usermodel/PaperSize.html

ochedru commented 1 year ago

Thank you for your PR! This new enum looks fine, I do not think we should reuse the one from POI because this would add a build dependency.

apptaro commented 1 year ago

thank you for merging this, too!