search

dhatim / fastexcel

Generate and read big Excel files quickly
Other
669 stars 121 forks source link

Feature support setting properties #242

Closed meiMingle closed 1 year ago

meiMingle commented 1 year ago

Close #164 . Hi,@ochedru Perhaps this PR should not be merged immediately, and there is another issue worth discussing. If you have time, please carefully review lines 154~196 of the new file Properties.java added by this PR. It may not be appropriate to set fmtid to a fixed value , but it works fine so far, I haven't found a more formal way to set this value. Looking forward to your suggestions to optimize it.

meiMingle commented 1 year ago

I think too much, the fmtId here is indeed a fixed value, refer to here and here. Now you can merge this PR with confidence @ochedru

ochedru commented 1 year ago

Thank you for your PR!