bug: duplicate check for websites && check for a website

dheerajdlalwani / back-to-work

A simple browser extension, intended to get you "Back To Work" when you start slacking off to one of those really addictive sites.

MIT License

36 stars 1 forks source link

bug: duplicate check for websites && check for a website #2

Open tusharnankani opened 2 years ago

tusharnankani commented 2 years ago

Duplicate check for websites.

Ah this is a fun problem ⬇ Edge cases:

Edit: Just saw, need a URL validator. I guess similar to what you built in the URL shortener.

dheerajdlalwani commented 2 years ago

Fixed the duplicate website issue & check for an actual website issue.
Just one thing: The format for adding a new website is: domain.tld
The extension currently does not support blocking specific pages of a website.
It either blocks the website completely or it does not block it.
Thank you so much for raising this issue 😄

tusharnankani commented 2 years ago

Hey!

Need to reopen this.

But apparently, the checks could be better!

Ah this is a fun problem ⬇ Edge cases:

That's why I said this XD

dheerajdlalwani commented 2 years ago

Right, makes sense. Totally forgot about it.. Reopening this. Although I do expect the user to sort enter the website in the given format. That's why the placeholder has a example.com But yes, why not just improve the checks...