Closed samimak37 closed 3 years ago
In find_gender_adj, there is an arbitrary 5 word limit for counting adjectives:
find_gender_adj
https://github.com/dhmit/gender_analysis/blob/ee1d41f1201202b9f608de8030c0059f0047d980/gender_analysis/analysis/gender_adjective.py#L9-L12
We should probably allow the user to define the window that they would like to search in. It looks like in the function we even have logic that coerces the function to use the value of 5:
https://github.com/dhmit/gender_analysis/blob/ee1d41f1201202b9f608de8030c0059f0047d980/gender_analysis/analysis/gender_adjective.py#L39-L47
(Returning a string in a function that is expected to return a dictionary -- maybe not the best move.)
This should be a simple fix, and doing so will cut out the need for so much checking logic
In
find_gender_adj, there is an arbitrary 5 word limit for counting adjectives:https://github.com/dhmit/gender_analysis/blob/ee1d41f1201202b9f608de8030c0059f0047d980/gender_analysis/analysis/gender_adjective.py#L9-L12
We should probably allow the user to define the window that they would like to search in. It looks like in the function we even have logic that coerces the function to use the value of 5:
https://github.com/dhmit/gender_analysis/blob/ee1d41f1201202b9f608de8030c0059f0047d980/gender_analysis/analysis/gender_adjective.py#L39-L47
(Returning a string in a function that is expected to return a dictionary -- maybe not the best move.)
This should be a simple fix, and doing so will cut out the need for so much checking logic