dhmit / gender_analysis

A toolkit for analyzing gendered language across sets of documents
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Added Test Coverage to Project #99

Closed samimak37 closed 4 years ago

samimak37 commented 4 years ago

Created the framework for formal tests and coverage analysis to be performed on the project.

samimak37 commented 4 years ago

It looks like Travis CI is complaining about me deleting the old doctest.py file. I'll work on getting the new GitHub Actions set up so this won't be a problem in the future.

mscuthbert commented 4 years ago

Probably don't need the doctest.py file anymore -- that was a system for testing that we never fully implemented when we moved to Django/React as a lab based system. Glad to see this system is evolving!

mscuthbert commented 4 years ago

(I'll let someone in the lab merge.)

ryaanahmed commented 4 years ago

Yep, no problems re: deleting doctest.py. That was a doctest runner that I wrote at the beginning of summer 19, and was actually fully redundant with a test runner @mscuthbert had already written for the lab (i.e., I should've checked if we already had one before writing it!).

I'd completely forgotten that we had Travis setup for this. @samimak37 let's not worry about the failure there, and focus on getting GitHub Actions setup.

Also, small concern, not blocking this merge: we specify paths to a test reddit corpus, but we also gitignore all the files in that path presently. Is the plan to eventually include a subset of that corpus in the repo?

merging!

samimak37 commented 4 years ago

Yes. Basically the test corpus that is in .gitignore has about 1000 files in it, and I didn't want to clog up the repo. If we want to add all of them back in it should be super easy, but I was planning on cleaning it up just a little bit as to avoid the mess.