dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.47k stars 189 forks source link

Doesn't load all AdNauseam filters #2268

Open romulasry opened 1 year ago

romulasry commented 1 year ago

Describe the issue

Doesn't load all filters in "496 used out of 498" and says update which does the same thing.

Screenshot in which the issue can be seen

Screenshot from 2023-02-11 18-27-47

Steps for anyone to reproduce the issue

(Please be as detailed as possible) Go to filters list and click update now.

Your settings

Your filter lists

Default + uBlock filters – Annoyances

Your location/country

Southern California, USA

** For adult or potentially offensive sites/ads, please add a [Content-Warning] tag in the title to warn developers the ticket may contain such material.

mneunomne commented 1 year ago

"496 used out of 498" is indeed interesting, where is this +1 coming from? Will check.

mneunomne commented 1 year ago

@romulasry here in ublock origin reddit there is some good clarification on that (this part of our system is directly inherited from ublock origin):

https://www.reddit.com/r/uBlockOrigin/comments/34tbgr/what_does_18438_used_out_of_18438_mean_in_the/

7000 out of 18438 are used - means that some rules are in other lists, too - e.g. when the same rule (or a whitelist of it) is in Easylist or uBlock filters – Unbreak‎ or any other list.

meaning, this is expected behavior, to avoid redundancy of filters. Same happens on uBlock Origin:

Screenshot 2023-02-14 at 18 06 10
mneunomne commented 1 year ago

(But still "496 used out of 498" seems wrong for obvious reasons)

romulasry commented 1 year ago

I think I remember having this bug on an old version of ublock origin and 1.46 fixed it.

mneunomne commented 1 year ago

thank you @romulasry good to know! We are curreltly doing the 1.45.0 merge, so hopefully this can be addressed soon.