search

dhylands / rshell

Remote Shell for MicroPython
MIT License
955 stars 136 forks source link

Don't try connect_telnet on Windows when '-p' is specified #233

Open github0null opened 3 months ago

github0null commented 3 months ago

Hello,

I noticed this case can't work on Windows, because windows serial port name usually is: 'COMxx', not include '/'

https://github.com/dhylands/rshell/blob/56f75cf846b2fd89f9a89c08a9dabd8015c30931/rshell/main.py#L1420-L1427

So it always try connect_telnet and elapse more time.

202