search

dialogos-project / dialogos

The DialogOS dialog system.
https://www.dialogos.app
GNU General Public License v3.0
21 stars 8 forks source link

DialogOS installer does not update installation #182

Open alexanderkoller opened 5 years ago

alexanderkoller commented 5 years ago

When DialogOS is already installed on a computer, the installer of a new release offers the user to either update the existing installation or to install into a new directory. If the user selects "update", the installer looks like it runs as expected; but when DialogOS is started, it is still the old version.

This happens both on MacOS and Windows, and is really dangerous, because users will think they are running the new version unless they're really paying attention.

@akoehn Do you have any idea why this might be happening?

akoehn commented 5 years ago

I'll have a look at the documentation.

akoehn commented 5 years ago

It is possible to automatically run the uninstaller from the previous installation if an installation with the same app-id was found. I created an untested branch with the necessary changes.

https://github.com/dialogos-project/dialogos-distribution/tree/uninstall-before-update

alexanderkoller commented 5 years ago

That would solve the immediate problem, thanks.

Is there really no more direct way in install4j to update an installation than to uninstall and then reinstall? This seems risky - e.g. the user has installed custom plugins below their DialogOS app, will they persist during uninstall?

akoehn commented 5 years ago

as far as I understand, it only removes the files that were actually installed before. It does not touch other files manually added later on.

I don't currently have time to further delve into the update mechanism of install4j. My suggestion: use the uninstall-on-update and have an issue for later so we don't forget it.