dialogos-project / dialogos

The DialogOS dialog system.
https://www.dialogos.app
GNU General Public License v3.0
21 stars 8 forks source link

Saving and loading voices in MaryTTS and AbstractOutputNode #215

Closed alexanderkoller closed 1 day ago

alexanderkoller commented 3 years ago

Describe the bug When saving and loading dialogs to/from a file, information about voices is not handled correctly:

To Reproduce It may be enough to select a non-default voice in a MaryTTS node and then save+load the dialog, but I have not tested this systematically. The problem arises because the default voice is selected first in AbstractOutputNode#readAttributes, and then overwritten by the correct value.

I am not entirely sure that there is a generic way to save and load voice information, because the voice objects are regenerated at each runtime and I don't quite trust the consistency of the voice names. This needs some looking into.

alexanderkoller commented 3 years ago

The voice handling in the Google TTS plugin seems to work correctly.