search

dialogos-project / dialogos

The DialogOS dialog system.
https://www.dialogos.app
GNU General Public License v3.0
21 stars 8 forks source link

Deleting ASR nodes breaks GUI #99

Closed alexanderkoller closed 6 years ago

alexanderkoller commented 6 years ago

Deleting a speech recognizer node first pops up a window that just says "Unexpected error: java.lang.NullPointerException". After this, the GUI is very wonky; e.g. deletion of edges no longer works.

In addition to fixing the bug itself, we should track down the way in which the NPE is caught and use the correct exception-reporting window instead.

The stacktrace of the exception, which is printed to the console, is as follows:

java.lang.NullPointerException
        at edu.cmu.lti.dialogos.sphinx.plugin.SphinxNode.getDefaultLanguage(SphinxNode.java:52)
        at com.clt.diamant.graph.nodes.AbstractInputNode.setGraph(AbstractInputNode.java:1189)
        at com.clt.diamant.graph.Graph.remove(Graph.java:622)
        at com.clt.diamant.graph.Graph.remove(Graph.java:596)
        at com.clt.diamant.undo.NodeEdit.delete(NodeEdit.java:64)
        at com.clt.diamant.undo.NodeEdit.run(NodeEdit.java:58)
        at com.clt.undo.Undo.addEdit(Undo.java:36)
        at com.clt.diamant.graph.ui.GraphUI$1.addEdit(GraphUI.java:160)
        at com.clt.diamant.graph.ui.GraphUI.deleteElements(GraphUI.java:2468)
        at com.clt.diamant.graph.ui.GraphUI.deleteSelection(GraphUI.java:2421)
        at com.clt.diamant.graph.ui.GraphUI.doCommand(GraphUI.java:1282)
        at com.clt.diamant.gui.SingleDocumentWindow.doCommand(SingleDocumentWindow.java:968)
        at com.clt.diamant.Main.doCommand(Main.java:627)
        at com.clt.gui.menus.CmdMenuItem$3.actionPerformed(CmdMenuItem.java:71)
        at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
        at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
        at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
        at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
        at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
        at javax.swing.AbstractButton.doClick(AbstractButton.java:356)
        at javax.swing.plaf.basic.BasicMenuItemUI$Actions.actionPerformed(BasicMenuItemUI.java:802)
        at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1663)
        at javax.swing.JComponent.processKeyBinding(JComponent.java:2882)
        at javax.swing.JMenuBar.processBindingForKeyStrokeRecursive(JMenuBar.java:699)
        at javax.swing.JMenuBar.processBindingForKeyStrokeRecursive(JMenuBar.java:706)
        at javax.swing.JMenuBar.processBindingForKeyStrokeRecursive(JMenuBar.java:706)
        at javax.swing.JMenuBar.processKeyBinding(JMenuBar.java:677)
        at javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:307)
        at javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:293)
        at javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2974)
        at javax.swing.JComponent.processKeyBindings(JComponent.java:2966)
        at javax.swing.JComponent.processKeyEvent(JComponent.java:2845)
        at java.awt.Component.processEvent(Component.java:6310)
        at java.awt.Container.processEvent(Container.java:2236)
        at java.awt.Component.dispatchEventImpl(Component.java:4889)
        at java.awt.Container.dispatchEventImpl(Container.java:2294)
        at java.awt.Component.dispatchEvent(Component.java:4711)
        at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1954)
        at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:806)
        at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1074)
        at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:945)
        at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:771)
        at java.awt.Component.dispatchEventImpl(Component.java:4760)
        at java.awt.Container.dispatchEventImpl(Container.java:2294)
        at java.awt.Window.dispatchEventImpl(Window.java:2746)
        at java.awt.Component.dispatchEvent(Component.java:4711)
        at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
        at java.awt.EventQueue.access$500(EventQueue.java:97)
        at java.awt.EventQueue$3.run(EventQueue.java:709)
        at java.awt.EventQueue$3.run(EventQueue.java:703)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
        at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
        at java.awt.EventQueue$4.run(EventQueue.java:731)
        at java.awt.EventQueue$4.run(EventQueue.java:729)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
        at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
        at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
        at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
alexanderkoller commented 6 years ago

It is possible that I broke something in AbstractInputNode when I refactored it for the Jython support. I will look into it.