Send Payjoin Fails to Sign occasionally

diba-io / bitmask-core

Core functionality for the BitMask wallet

https://bitmask.app

Other

95 stars 23 forks source link

Send Payjoin Fails to Sign occasionally #424

Closed DanGould closed 10 months ago

DanGould commented 10 months ago

Payjoin will occasionally Fail to Sign because original input is skipped rather than checked against the next proposed input. This original_input.next() check should be moved inside the curly braces

https://github.com/diba-io/bitmask-core/blob/af40bc05d3e93d4392d4376da0ddff7cede59a77/src/bitcoin/payment.rs#L177C16-L179

DanGould commented 10 months ago

see releated code fix in mutiny-node

https://github.com/DanGould/mutiny-node/blob/4883b784e19edb5100a0cb56671176549feeb50d/mutiny-core/src/onchain.rs#L500-L519