search

dickinson-comp190 / GitKit-FarmData2-F23

Other
0 stars 20 forks source link

Seeding Report: Tray Seeding Summary NaN Values for Total Number and Average Seeds Planted #69

Open QuangPhung15 opened 10 months ago

QuangPhung15 commented 10 months ago

In the Tray Seeding Summary table at the bottom of the page Seeding Report from the BarnKit tab, sometimes the "Total Number of Tray Seeds Planted" and "Average Seeds Planted per Hour" showed the value of NaN, not the actual values.

Step to replicate:

  1. Visit the Seeding Report from the BarnKit tab.
  2. Change the Start Date to 01/01/2019 and the End Date to 05/13/2019.
  3. Scroll down to the bottom of the page.

Screen Shot 2023-10-25 at 9 12 51 PM

Expected Result: In the Tray Seeding Summary table at the bottom of the Seeding Report, the "Total Number of Tray Seeds Planted" and "Average Seeds Planted per Hour" should display proper numerical values representing the total number of seeds planted and the average seeds planted per hour, respectively.

Observed Result: Sometimes, when viewing the Seeding Report with a specific date range, the "Total Number of Tray Seeds Planted" and "Average Seeds Planted per Hour" fields display NaN (Not a Number) instead of the expected numerical values. This behavior appears to be date range-dependent, and not consistent. For some date ranges like before 05/13/2019, these fields correctly show numerical values, while for others, they incorrectly show NaN.

OS Observed: Chrome on Mac OS.

linhkhanhhoang commented 10 months ago

Your ticket looks great but I think it will be better if you specify your macOS version :3

MaxiSanc37 commented 10 months ago

Loved to see the step-by-step on how to replicate the bug, the description is very concise and effective. I also think that the expected and observed result sections are very useful and it was a good idea to add the OS of the machine you were using when you encountered the bug. I feel like the only thing missing would be narrowing down the example to the most minimal example since the date range of the generated seed report is very large and there is an actual smaller example.

SpencerGoodman commented 10 months ago

Very good ticket. I enjoyed how it even provided what OS the issue occurred on. I believe that it could have possibly narrowed down the dates more to find exactly what dates are causing the issue.

ZachLeibman commented 10 months ago

Great job. If i had to make a suggestion it would be to add a potential cause or solution tab.