Fix Kaldi grammar loading/unloading while in phrase

dictation-toolbox / dragonfly

Speech recognition framework allowing powerful Python-based scripting and extension of Dragon NaturallySpeaking (DNS), Windows Speech Recognition (WSR), Kaldi and CMU Pocket Sphinx

GNU Lesser General Public License v3.0

388 stars 75 forks source link

Fix Kaldi grammar loading/unloading while in phrase #304

Closed daanzu closed 3 years ago

daanzu commented 4 years ago

This is for merging after PR #302.

@Timoses Can you test this and see if it solves the crashing/errors in #286 ? You can use the KaldiAG dev wheel version.

drmfinlay commented 3 years ago

@daanzu Should this be rebased and merged now?

Timoses commented 3 years ago

Thumbs up from my side. I did leave comments on it here:

Whereas the first comment was using a wrong branch. -> Should be good.

drmfinlay commented 3 years ago

Okay then, thanks @Timoses. I've rebased and retested this. I'll merge it now and release a new version today or tomorrow. Thanks again @daanzu and sorry for taking so long to deal with this!