Delete unnecessary `join` from stock center phenotype export

[biodavidjm]

The following SQL statement from modware-dump contains two extra unnecessary joins:

/* Phenotype (7742) -> strain_phenotype.tsv */
SELECT g.uniquename dbs_id, phen.name phenotype, env.name environment, assay.name assay, pub.uniquename pmid, p.value phenotype_note
FROM phenstatement pst
LEFT JOIN genotype g on g.genotype_id = pst.genotype_id
LEFT JOIN cvterm env on env.cvterm_id = pst.environment_id
LEFT JOIN cv env_cv on env_cv.cv_id = env.cv_id
LEFT JOIN phenotype p on p.phenotype_id = pst.phenotype_id
LEFT JOIN cvterm phen on phen.cvterm_id = p.observable_id
LEFT JOIN cvterm assay on assay.cvterm_id = p.assay_id
LEFT JOIN cv assay_cv on assay_cv.cv_id = assay.cv_id
LEFT JOIN pub on pub.pub_id = pst.pub_id
ORDER BY g.uniquename, pub.uniquename, phen.name;

These 2 JOINs can be removed:

LEFT JOIN cv env_cv on env_cv.cv_id = env.cv_id
LEFT JOIN cv assay_cv on assay_cv.cv_id = assay.cv_id

To do:

• [ ] Create new branch
• [ ] Modify the method find_phenotypes from the package Modware::Role::Stock::Export::Strain: remove both lines.
• [ ] Unit test it, pull request and merge.

[cybersiddhu]

31