diegomura / react-pdf

📄 Create PDF files using React
https://react-pdf.org
MIT License
15.02k stars 1.19k forks source link

fix: add scheduler dependency #2958

Closed diegomura closed 1 week ago

diegomura commented 1 week ago

Closes #2956

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 9172675f86a5455c7c15cc0fecede9a3c35a4487

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages | Name | Type | | ----------------------- | ----- | | @react-pdf/reconciler | Patch | | @react-pdf/renderer | Patch | | next-14 | Patch | | next-15 | Patch | | @react-pdf/vite-example | Patch | | @react-pdf/e2e-node-cjs | Patch | | @react-pdf/e2e-node-esm | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

AdrianMrn commented 1 week ago

Hey @diegomura, it doesn't seem this fixed the error 🤔 not sure why, but even though I'm getting @react-pdf/reconciler@1.1.2, it doesn't seem like scheduler is included in my installed dependencies.

Maybe scheduler needs to be added under peerDependencies or dependencies instead of devDependencies? https://github.com/diegomura/react-pdf/blob/%40react-pdf/reconciler%401.1.2/packages/reconciler/package.json

Thanks a lot for this package btw, it's been super helpful to me :)

mariuskalvo commented 1 week ago

@AdrianMrn I had the same issue after upgrading to 4.1.4. Deleting and regenerating the package-lock.json file solved the problem for me. scheduler is no longer defined as a dependency for @react-pdf/renderer in lockfile 🙂