search

diesel-rs / diesel

A safe, extensible ORM and Query Builder for Rust
https://diesel.rs
Apache License 2.0
12.57k stars 1.05k forks source link

More code reviewers wanted! #1186

Open sgrif opened 7 years ago

sgrif commented 7 years ago

With the push to 1.0, the current pool of reviewers is starting to run low on bandwidth. We're looking for more people to help get involved with code review. You don't need to be familiar with Diesel's internals to help. Most people who have been on the Diesel core team got started by doing code review. If you're unsure what a piece of code does or why it's being done a certain way, just ask! (Make sure that the commit message doesn't answer that question already though). Don't feel like you can't ask a question just because other reviewers might already know the answer. We're happy to help you get up to speed.

juliusdelta commented 7 years ago

Nice. Is the best way to get started to just review and add comments/questions to PRs?

sgrif commented 7 years ago

Yup. If you'd like I can add you to the github group which gets pinged for code review

juliusdelta commented 6 years ago

Sure that’d be great!

toddWannaCode commented 6 years ago

I am really interested in this but I am just getting started with diesel.

killercup commented 6 years ago

@toddWannaCode that's absolutely fine! Most PRs are quite isolated in scope so you don't need to know everything beforehand. :) Feel free to have a look at and review PRs to get a feel for it, and if you like it, ping me (or another core team member) and we'll add you to the reviewers team.

leshow commented 6 years ago

I'd be interested in jumpiing into some code reviews, if you folks are still looking for people.

killercup commented 6 years ago

Absolutely! Want me to add you to the Reviewers team?

Evan Cameron notifications@github.com schrieb am So. 24. Sep. 2017 um 23:22:

I'd be interested in jumpiing into some code reviews, if you folks are still looking for people.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/diesel-rs/diesel/issues/1186#issuecomment-331741068, or mute the thread https://github.com/notifications/unsubscribe-auth/AABOX5OL_jjKy7inV3oLryKG0EqflFLaks5slsgOgaJpZM4Pf3MF .

toddWannaCode commented 6 years ago

Hey I would be like to be a member of the Reviewers team. Thanks. @killercup

killercup commented 6 years ago

@toddWannaCode, welcome to the league of extraordinary reviewers! :)

leshow commented 6 years ago

@killercup Sure, sounds good.

killercup commented 6 years ago

@leshow, welcome to the Four Nine Horsemen of the Code Review!

ecasilla commented 6 years ago

Count me in also. I would love to help anyway I can.

killercup commented 6 years ago

@ecasilla, thank you for joining the Order of Magnitude!

ecasilla commented 6 years ago

@killercup How will the mentoring work exactly is there a gitter for the core team?

sgrif commented 6 years ago

@ecasilla You can ask questions either in the public gitter or as comments on the PRs you're trying to review (feel free to ask questions after things have been closed/merged as well)

gsquire commented 6 years ago

I don't have much experience in the codebase but I'd like to help review.

jbcden commented 6 years ago

I'm a bit late to the party and I haven't really gotten a chance to use diesel, but I'm trying to get into Rust more and would love to help with reviews!

bahlo commented 6 years ago

Hey, I'd also like to be in the review team.

hrvolapeter commented 6 years ago

Hi, count me in

sgrif commented 6 years ago

@retep007 I've added you to the team -- You'll get pinged on future PRs, but feel free to review any of the open PRs in the mean time. There's quite a few open right now.

sgrif commented 6 years ago

(Note: Everyone who's replied to this has been added shortly after replying, I'm only singling that person out because there happens to have been an extremely high volume of PRs opened in the past 24 hours and I assumed the were around right now)

sgrif commented 6 years ago

I should also mention -- If anyone tries to review a PR, and feels like they don't understand enough to properly review it, please ask questions on the PR. We don't mind explaining things that aren't clear, and hearing what needs more context before the PR is opened is extremely helpful.

logotie commented 6 years ago

Hello all, is there any chance I could please be added also? I am however very much a beginner with Rust :)

sgrif commented 6 years ago

Hey folks, just a heads up, I did some cleanup tonight. Anyone who hasn't commented on an issue in the past month will have been removed. If you'd like to be re-added, please comment again on this issue.

JohnTitor commented 5 years ago

Hi @sgrif, let me help you with reviewing! Diesel is used in my work, so improving Diesel is also important task.

weiznich commented 5 years ago

@JohnTitor I've added you to the reviewer team.

AlterionX commented 4 years ago

I would like to do some code review work! It's been lots of fun using Diesel, and I would like to get a good grasp of the internals.

weiznich commented 4 years ago

@AlterionX I've added you to the corresponding team. You should now get notifications on requested reviews. Feel free to ask questions everywhere where something is unclear.

Razican commented 4 years ago

Hi! I would like to be added as a reviewer. I'm not familiar with Diesel internals, but I know Rust and would like to help and learn :)

weiznich commented 4 years ago

@Razican I've added you to the corresponding team. You should now get notifications on newly requested reviews. If you want you could also check existing PR's. Feel free to ask questions anywhere where something is unclear, we will try to explain it :wink:

If you don't want to be at the reviewer team any more at some point of time just tell us that and we will remove you from the list that get's pinged on new PR's.

FlorentinDUBOIS commented 4 years ago

Hi! I will be glad to help you to review some pull requests, I'm not familiar with diesel but I have played a lot with hyper and tokio. I think I could help :)

weiznich commented 4 years ago

@FlorentinDUBOIS I've sent you a invitation for the reviewer team. You should now get notifications on newly requested reviews. If you want you could also check existing PR's. Feel free to ask questions anywhere where something is unclear, we will try to explain it 😉

If you don't want to be at the reviewer team any more at some point of time just tell us that and we will remove you from the list that get's pinged on new PR's.

danidoni commented 4 years ago

Hi! I'm interested also! I know a bit of Rust, but I'm interested into learning and finding a place to contribute :grin:

weiznich commented 4 years ago

@danidoni I've sent you an invitation. As mentioned above feel free to ask questions anywhere where something is unclear. It's totally fine (and encouraged) to ask at a PR how something works.

jdlambert commented 4 years ago

I'm interested in reviewing PRs as well!

weiznich commented 4 years ago

@jdlambert I've sent you an invitation. Everything else as written above.

BrettMayson commented 4 years ago

I'm new to diesel but been using Rust for quiet a while, if you need more added shoot me an invite please

weiznich commented 4 years ago

@synixebrett I've sent you an invitation. Everything else as written above.

weiznich commented 4 years ago

@diesel-rs/reviewers We are interested in getting reviews on the PR's in the diesel 2.0 milestone. I know some of them are quite complicated, so especially there: Please ask questions about everything that is unclear.

ELD commented 4 years ago

@weiznich Are you still looking to recruit more reviewers for Diesel? I’d be happy to lend a hand!

weiznich commented 4 years ago

@ELD We are still looking for reviewers. I've sent you an invitation. As written above reviews on any PR's are appreciated. If there is anything unclear about some code just ask and someone will try to explain it. (This also applies to unrelated code).

TaKO8Ki commented 4 years ago

Hi, I'm interested in reviewing PRs as well!!

weiznich commented 4 years ago

@TaKO8Ki I've sent you a invitation. Feel free to review any open still active PR. Also do not hesitate to ask any question about how some code works as part of your review (even if not related to the specific PR). We will try to answer that as good as possible.

henryboisdequin commented 3 years ago

Hello, I am interested in reviewing PRs and writing them as well!

weiznich commented 3 years ago

@henryboisdequin I've sent you a invitation. Feel free to submit a review at any existent active PR. If there is anything unclear about some part of the code just ask at the corresponding PR or in our gitter channel. If you need help contributing code just ask questions at the corresponding issue or again in our gitter channel. Also opening a WIP PR is encouraged, as central place for discussions about the actual implementation of specific features. If you don't want to be part of the corresponding team anymore, just drop me a message.

Rustin170506 commented 3 years ago

Hi @weiznich ,I've already done some commits for diesel, but I'd like to get more involved in the project. I'm currently very interested in how to implement an ORM, so I'd like to submit more PRs and review PRs (although there is still a lot of code I don't understand at the moment).

weiznich commented 3 years ago

@hi-rustin I've sent you a invitation. We are always happy to have more people to work on diesel. Feel free to reach out if anything about any part of the code is unclear.

BobbyByrne commented 2 years ago

Hi, I've been learning Rust for a few months now and I'm starting to dip my toes in helping out open source projects. Diesel seems very cool and I work with DBs frequently. I'd love to be added to the reviewer team to hopefully help and learn from everyone.

weiznich commented 2 years ago

@BobbyByrne I added you to the corresponding team. You should now get a ping each time there is a review necessary. Feel free to ask any question at a PR, even if it's not related to the PR itself. I will try to answer them. Otherwise #2931, #2935 and #2626 are in progress PR's that could get an additional view. Feel free to reach out if anything about any part of the code is unclear.

deepu9 commented 2 years ago

Hi, I've been learning Rust and would like to get involved in Diesel. Can you add me to the PR reviewers list. Thanks