search

diffix / reference

Reference implementation for the Open Diffix anonymization mechanism.
https://www.open-diffix.org
Other
3 stars 0 forks source link

Fix bug where count(value) in the query clashes with *-bucket hook #338

Closed pdobacz closed 2 years ago

pdobacz commented 2 years ago

Without this fix, the finding function in CommonTypes would find both DiffixCount (i.e. count(*), count(value)) and on two finds, it would return a None resulting in an error Cannot find required DiffixCount aggregator.

The hasOnlyAidArgs is very opportunistic and brittle, is there a better and still easy way?

edongashi commented 2 years ago

The hasOnlyAidArgs is very opportunistic and brittle, is there a better and still easy way?

I think count star has only one argument (AIDs), whereas count value has 2 (aids, value). Aggregator.fs L141 verifies this.

pdobacz commented 2 years ago

The hasOnlyAidArgs is very opportunistic and brittle, is there a better and still easy way?

I think count star has only one argument (AIDs), whereas count value has 2 (aids, value). Aggregator.fs L141 verifies this.

Yup, so this little function tests for that, but it might be easy for this function's assumptions to get out of sync with reality.