diffpy / diffpy.fourigui

Other
0 stars 7 forks source link

remove `.coveragerc` file #58

Closed cadenmyers13 closed 3 weeks ago

cadenmyers13 commented 3 weeks ago

closes #57. With tests at top level, we no longer need to omit any files as pytest automatically detects files in tests. https://github.com/Billingegroup/cookiecutter/pull/177#discussion_r1826404794

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.49%. Comparing base (4c40b78) to head (38afb09). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## =========================================== + Coverage 69.85% 93.49% +23.63% =========================================== Files 3 4 +1 Lines 345 169 -176 =========================================== - Hits 241 158 -83 + Misses 104 11 -93 ``` [see 7 files with indirect coverage changes](https://app.codecov.io/gh/diffpy/diffpy.fourigui/pull/58/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=diffpy)
cadenmyers13 commented 3 weeks ago

This isn't passing after I made a second push, similar to the other PR here https://github.com/diffpy/diffpy.fourigui/pull/55

Edit: Looks like this is an active issue faced by others. I've created an issue for this. Solution is being worked out here but will look into this: https://github.com/codecov/codecov-action/issues/1580

sbillinge commented 3 weeks ago

@cadenmyers13 also, this is failing tests. Some issue with codecov

github-actions[bot] commented 3 weeks ago

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, please add a news item by copying the format from news/TEMPLATE.rst.

cadenmyers13 commented 3 weeks ago

@sbillinge Yeah... there's a github thread here discussing it: https://github.com/codecov/codecov-action/issues/1580

sbillinge commented 3 weeks ago

Thanks @cadenmyers13

Looks like the codecov problem is resolved too!