digdir / designsystemet

Designsystemet
https://designsystemet.no
MIT License
85 stars 38 forks source link

fix(FieldAffix): affix as single element #2771

Closed eirikbacker closed 1 week ago

eirikbacker commented 2 weeks ago

Fixes #2748 Awaiting feedback regarding text vs icons support from @Febakke

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 260bdbd8b107085a1a6b0c5cff40bfde7fad6aa7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ---------------------------- | ----- | | @digdir/designsystemet-css | Patch | | @digdir/designsystemet-react | Patch | | @digdir/designsystemet | Patch | | @digdir/designsystemet-theme | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 weeks ago

Preview deployments for this pull request:

Storybook - 12. Nov 2024 - 10:18

github-actions[bot] commented 2 weeks ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.93% 3069 / 5690
🔵 Statements 53.93% 3069 / 5690
🔵 Functions 86.29% 170 / 197
🔵 Branches 75% 459 / 612
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/form/Field/FieldAffix.tsx 100% 100% 100% 100%
packages/react/src/components/form/Textfield/Textfield.tsx 93.61% 85.71% 100% 93.61% 103-105
Generated in workflow #878 for commit 260bdbd by the Vitest Coverage Report Action
eirikbacker commented 1 week ago

Closing as we want to keep ability to add icons: https://github.com/digdir/designsystemet/issues/2748#issuecomment-2482393128