coderabbitai[bot]
commented
3 weeks ago 📝 Walkthrough
## Walkthrough The pull request introduces significant updates to K6 performance testing workflows and scripts. The workflow configuration is modified to change default parameters and add new input requirements. Several new files are created for testing GraphQL and end-user functionalities, while existing scripts are updated to improve data handling and error management. Additionally, the removal of outdated performance scripts is noted. Overall, these changes enhance the structure and flexibility of performance testing across various scenarios. ## Changes | File Path | Change Summary | |------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `.github/workflows/dispatch-k6-performance.yml` | - Updated `environment` default value from 'staging' to 'yt01'.- Added required input parameter `tag` with default value 'Performance test'.
- Changed `vus` default value from 10 to 1.
- Updated `testSuitePath` options and removed old options.
- Updated `run-name` to include dynamic inputs. | | `tests/k6/common/config.js` | - Added new base URL constants for various environments.
- Updated `baseUrls.v1` to use these constants and added a new `graphql` property.
- Introduced `baseUrlGraphql` constant. | | `tests/k6/common/request.js` | - Added import for `baseUrlGraphql`.
- Introduced new function `postGQ` for making GraphQL requests. | | `tests/k6/common/testimports.js` | - Added new export for `postGQ` from `./request.js`. | | `tests/k6/tests/enduser/performance/simple-search.js` | - Removed the entire performance testing script. | | `tests/k6/tests/performancetest_data/01-create-dialog.js` | - Introduced a new function for generating dialog objects for performance testing, including validation and cleanup logic. | | `tests/k6/tests/performancetest_data/graphql-search.js` | - Added new function `getGraphqlParty` for constructing GraphQL query strings. | | `tests/k6/tests/scripts/generate_tokens.sh` | - Modified handling of the `API_ENVIRONMENT` variable to assign "yt01" for the "performance" case. | | `tests/k6/tests/serviceowner/performance/create-dialog.js` | - Updated imports and restructured data handling.
- Replaced `thresholds` property with a call to `getDefaultThresholds`.
- Removed previous implementation of the `createDialog` function. | | `tests/k6/tests/serviceowner/performance/create-remove-dialog.js` | - Enhanced imports and updated performance testing framework to include dynamic thresholds and conditional execution logic. | | `.github/workflows/workflow-run-k6-performance.yml` | - Added `environment` property to the `k6-test` job to utilize specified environment directly. | | `tests/k6/tests/enduser/performance/enduser-search.js` | - Introduced a new performance testing script for end-user search functionality with dynamic thresholds. | | `tests/k6/tests/graphql/performance/graphql-search.js` | - Added a new performance testing script for GraphQL search functionality with flexible execution paths. | | `tests/k6/tests/performancetest_common/createDialog.js` | - Introduced `createDialog` and `createAndRemoveDialog` functions for dialog creation and deletion tests. | | `tests/k6/tests/performancetest_common/getDefaultThresholds.js` | - Added a new function to create a default thresholds configuration for K6 performance tests. | | `tests/k6/tests/performancetest_common/readTestdata.js` | - Introduced functionality for loading and parsing CSV data files for service owners and end users. | | `tests/k6/tests/performancetest_common/simpleSearch.js` | - Introduced functions for testing dialog retrieval and search operations, including error handling and response validation. | | `tests/k6/tests/scenarios/performance/create-dialog-and-search.js` | - Introduced performance testing scenarios for creating dialogs and executing searches with structured options and metrics. | ## Possibly related PRs - **#875**: Enhances authorization checks for dialog entities, potentially impacting performance tests involving dialogs. - **#1110**: Introduces a new activity type related to dialogs, relevant for performance tests tracking dialog states. - **#1240**: Adds tests for the optional `EndUserId` parameter, which may relate to performance tests for different user scenarios. - **#1331**: Directly aligns with the main PR by introducing performance tests for creating dialogs and searching. - **#1367**: Fixes input handling in the K6 dispatch workflow, directly related to updates in the K6 performance testing workflow. - **#1372**: Enhances cleanup functionality for unpurged dialogs, relevant for maintaining test state during performance tests.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
sonarcloud[bot]
Description
Added more performance tests and some improvements on github workflow for performance tests
Related Issue(s)
1326
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Documentation