fix(service): ensure correct maskinporten environment

arealmaas commented 2 weeks ago

Description

Related Issue(s)

N/A

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

New Features
- Introduced a new configuration key, TokenExchangeEnvironment, across multiple environments (prod, staging, test, yt01) to enhance service configuration.
Bug Fixes
- Adjusted formatting for consistency in the Redis section of staging and test configurations.

coderabbitai[bot] commented 2 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough

## Walkthrough The changes involve the addition of a new key-value pair, `"TokenExchangeEnvironment"`, to the "Maskinporten" section across multiple configuration files (`appsettings.prod.json`, `appsettings.staging.json`, `appsettings.test.json`, and `appsettings.yt01.json`). Each file receives a different value for this key, while existing keys and overall structure remain unchanged. The updates maintain the integrity of the configuration settings, ensuring that sensitive information is to be managed securely. ## Changes | File Path | Change Summary | |---------------------------------------------------|-----------------------------------------------------------| | `src/Digdir.Domain.Dialogporten.Service/appsettings.prod.json` | Added key `"TokenExchangeEnvironment": "prod"` in "Maskinporten" section. | | `src/Digdir.Domain.Dialogporten.Service/appsettings.staging.json` | Added key `"TokenExchangeEnvironment": "tt02"` in "Maskinporten" section; adjusted `Redis` section formatting. | | `src/Digdir.Domain.Dialogporten.Service/appsettings.test.json` | Added key `"TokenExchangeEnvironment": "tt02"` in "Maskinporten" section; reformatted `Redis` section; minor formatting issue noted. | | `src/Digdir.Domain.Dialogporten.Service/appsettings.yt01.json` | Added key `"TokenExchangeEnvironment": "yt01"` in "Maskinporten" section. | ## Possibly related PRs - **#1328**: Adds the `"TokenExchangeEnvironment"` key in the `appsettings.prod.json` file. - **#1329**: Introduces a new configuration file `appsettings.yt01.json` that includes the `"TokenExchangeEnvironment"` key. - **#1312**: Adds the `"TokenExchangeEnvironment"` key in multiple `appsettings.yt01.json` files across different modules. - **#1315**: Adds the `"TokenExchangeEnvironment"` key in the `appsettings.Development.json`. - **#1320**: Adds the `"TokenExchangeEnvironment"` key in the `appsettings.staging.json`. - **#1328**: Adds the `"TokenExchangeEnvironment"` key in the `appsettings.test.json`. ## Suggested reviewers - knuhau

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.