diggerhq / helm-charts

Apache License 2.0
8 stars 6 forks source link

Default values file includes data which should not be default #11

Open dannysauer opened 2 weeks ago

dannysauer commented 2 weeks ago

Default values for ingress include a new ingress class name of "test" which breaks existing ingress implementations which previously specified the ingress annotation kubernetes.io/ingress.class: nginx (except in the extremely unlikely situation where someone is using an ingress class of "test"). Aside from the breakage, it includes several additional default values which would be inappropriate in an active deployment. Those should probably be a commented-out example. :)

https://github.com/diggerhq/helm-charts/blob/main/charts/digger-backend/values.yaml#L45-L55