search

digininja / CeWL

CeWL is a Custom Word List Generator
1.96k stars 258 forks source link

Gemfile and README.md conflict #73

Closed ZeroChaos- closed 3 years ago

ZeroChaos- commented 3 years ago

README.md says "mime-types" and "rubyzip" are required, but the Gemfile actually calls for "zip" and "mime" which are different gems.

Afaik, the ones specified in README.md are the "preferred" gems to use. Can you please correct Gemfile, Gemfile.lock, and confirm the code actually uses the right gems? At least the zip gem seems to be called directly, I can't tell for mime because I know less about it.

digininja commented 3 years ago

I'll have a look at and see.

Can't say off the top of my head as I've no idea which is which.

On Fri, 5 Mar 2021 at 15:28, Zero_Chaos notifications@github.com wrote:

README.md says "mime-types" and "rubyzip" are required, but the Gemfile actually calls for "zip" and "mime" which are different gems.

Afaik, the ones specified in README.md are the "preferred" gems to use. Can you please correct Gemfile, Gemfile.lock, and confirm the code actually uses the right gems? At least the zip gem seems to be called directly, I can't tell for mime because I know less about it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/digininja/CeWL/issues/73, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWKIX675AF2MJXUFUHDTCD2DNANCNFSM4YVNCAUA .

blshkv commented 3 years ago

It's sad to see a new release without this fix. Ping?

digininja commented 3 years ago

Feel free to submit a PR, if not, I'll try to get to it soon.

On Sun, 23 May 2021, 01:09 Anton Bolshakov, @.***> wrote:

It's sad to see a new release without this fix. Ping?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/digininja/CeWL/issues/73#issuecomment-846479429, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWIYQG52Z32MX5WKWLLTPBBTTANCNFSM4YVNCAUA .

digininja commented 3 years ago

The only mistake in the README was rubyzip which should have been zip, I've fixed that.