search

digistump / OakCore

Arduino/Platformio Core for Oak including Particle library
GNU Lesser General Public License v2.1
55 stars 28 forks source link

Allow the current mode to be queried #63

Closed kh90909 closed 8 years ago

kh90909 commented 8 years ago

@digistump how would you feel about adding the ability to query the mode (config/user/update) an Oak is in, using the method in this pull request or similar? This would allow us to query and display the current mode in OakTerm.

If so, is this the correct logic to determine the current mode, or are there special cases that need to be accounted for?

digistump commented 8 years ago

This is a great idea - thanks! Any compelling reason for the ? after mode - seems like it might be worth avoiding any none alphanumeric characters just for clarity/encoding safety/etc,etc

kh90909 commented 8 years ago

The ? is just intended to signify this is a query rather than a command, similar to the SCPI protocol used for interfacing with electronic test instruments.

But, there's no compelling reason it has to be a question mark. Perhaps mode query or current mode or similar instead?

digistump commented 8 years ago

Merged but I took the ? mark - just "mode" seems good to me