Notify LPAs that their brownfield land data needs updating

[CharliePatterson]

Context:

• LPAs are required to review their brownfield land data each year, and update their brownfield land register.
• They can use the Submit service to check and submit their data.
• The service should inform them that this needs to happen, and should guide them through the process of checking and submitting their data.
• This will take the form of a notification banner on the dashboard page.
• And also updating the lpa dashboard page to include a notice under the BFL card
• Rabbit hole for a second iteration: Tell users when their data is overdue.

ToDo

• [x] #635
• [x] #638
• [x] #636
• [x] #637

additional

• [x] add notice banners to the top of the notice's dataset's details page
• [ ] tighten up schema for notice

Tests to write

• [x] update aggregate overview tests
• [x] datasetSubmissionDeadlineCheck
• [x] getDeadlineHistory
• [x] addNoticesToDatasets
• [x] set notices from source key
• [ ] datasetOverview.html
• [x] overview.html

Rules for when the banner should show:

• The notification banner should only show when the LPA needs to update their brownfield land data.
• The long-term solution for this should be a data quality measure that comes via the pipeline (potentially either a set of rules that looks at when the latest endpoint was added or updated, or a more definitive label supplied by the user at time of submission), but in the interim we should bake the logic for this into the service.
• The proposal for this is here.

Acceptance criteria:

• As a data provider, when our brownfield land data needs to be updated, the service shows a notification on the dashboard page that alerts me to this, and links me to the step-by-step page to explain what I need to do.

Designs:

[GeorgeGoodall-GovUk]

@CharliePatterson @MJFaucherFolie For now I'll just consider their latest BFL endpoint, though perhaps we can talk about this more in the meeting later

[GeorgeGoodall-GovUk]

@alextea @maddie-broxup Hey both, this ticket also involves adding in an overdue notice.

for now I've just put in this while I'm finishing of development.

could you guys let me know how exactly you want it? thanks

[maddie-broxup]

Hey @GeorgeGoodall-GovUk, have attached an image of the content below.

I added it to ticket #638 and not this one, sorry!

Heading: Your brownfield land dataset is overdue Paragraph text: It was due on 31 December 2024. Link text: Follow the steps and check your data meets the specifications before you publish and submit it.

[GeorgeGoodall-GovUk]

awesome, thanks @maddie-broxup I'll put that in now

[GeorgeGoodall-GovUk]

also one more thing, how will this reflect in the hint under the card?

[maddie-broxup]

@GeorgeGoodall-GovUk The text under the 'Brownfield land' link should say: You must update this dataset by 31 December 2024

[GeorgeGoodall-GovUk]

@maddie-broxup even when overdue? or should the message be different for that?

[maddie-broxup]

Ah sorry @GeorgeGoodall-GovUk yeah you're right - can we make this "This dataset is overdue"?

[GeorgeGoodall-GovUk]

sounds good! thanks :D

[GeorgeGoodall-GovUk]

extending this ticket slightly as we want this on the BFL dataset details page too now

[neilfwar]

Spilling over due to merge conflicts causing test fail - likely completed 20 Nov