Material design strategy

[mattcollier]

This is a general question which happens to have immediate application to this component.

We currently have need of a material themed version of this component. What is our strategy for incorporating material design buttons and inputs etc.?

Are we wholesale replacing boostrap classes with material design and making a major release?

[dlongley]

We should do what we did with the others and create a 'theme' option. When it is set to 'material', we will do this:

"...wholesale replacing bootstrap classes with material design"

And then when that's done we can just a do a minor release with the new feature.

[mattcollier]

@dlongley so I'm clear on your suggestion...

you're saying that everywhere we have a we would need to do

<md-button ng-if="$ctrl.theme === 'material'" ...>
<button ng-if="$ctrl.theme !== 'material'" ...>

Is that right?

If we really want to support multiple themes, is there a more generalized approach we can take?

Having to create the kind of boilerplate described above for every button we create in new and existing components does not seem like a good strategy.

So, for example, would it make more sense to create a <br-button br-theme='material'> sort of component?

[dlongley]

@mattcollier,

If we really want to support multiple themes, is there a more generalized approach we can take?

Yes, we could, for example, have a generalized "theme" service that bedrock components use, but we haven't had time to design and implement that. So I went with "do whatever the other components have been doing so far to get it done quickly".

So, for example, would it make more sense to create a sort of component?

I'm ok with that approach for now as well. It's a good idea anyway to give us better control over styling common buttons in general.