search

digitalcraftsman / hugo-strata-theme

Port of HTML5UP's Strata theme to Hugo
Other
143 stars 92 forks source link

Added Gitlab icon to footer #24

Closed gschaffner closed 7 years ago

gschaffner commented 7 years ago

@digitalcraftsman

gschaffner commented 7 years ago

Using this, my build gives the error: ERROR: 2017/01/05 20:24:55 general.go:236: theme/partials/footer.html is an incomplete or empty template

gschaffner commented 7 years ago

That build error had been fixed.

Now, the site generates and the GitLab icon can be seen in the footer using inspect element, but the icon is not visible.

image

image

In the generated html, it seems that the GitLab icon is missing a ::before.

gschaffner commented 7 years ago

I believe (but I may be wrong) that @digitalcraftsman needs to update his font awesome config to include gitlab?

digitalcraftsman commented 7 years ago

Hello @FISHunderscore,

thanks for your submission. I merged it as 01b840ead26cce003724b82207f557879ddc61f9. In a following commit I updated the version of fontawesome that includes the GitLab icon.

Regards, Digitalcraftsman