digitalfabrik / entitlementcard

App for 'Digitale Berechtigungskarten', generally benefit card for volunteers or socially vulnerable groups in Germany. App for Android & iOS + Backend + Administration Web Portal – 100% Open Source.
MIT License
36 stars 3 forks source link

Revoke existing cards via HTTP endpoint #1415

Open ztefanie opened 5 months ago

ztefanie commented 5 months ago

Is your feature request related to a problem? Please describe. Adjust the existing HTTP PUT endpoint, so it will revoke existing cards, when the expiration date is set to a date in the past.

Describe the solution you'd like

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context For testing:

blocked by #1419 blocked by #1424 blocked by #1431

f1sh1918 commented 2 weeks ago

@ztefanie i'm not pretty sure if we really need #1419 and #1431 for this. I think this function will be triggered after each csv import and should just set the card revoked = true . We can just create a proper backend test for testing this. If the card was activated or not is not important. In the frontend we already can test the case if a card is revoked that it can't be activated or used. Even we can not test that for koblenz at the moment, i think we can start this task after #1424

ztefanie commented 2 weeks ago

@f1sh1918 sure feel free to adjust/edit the text. I like testing issues and everything connected to it, when developing and see no real point of doing this before the other tickets, but feel free to do so, if you have a strong opinion on this.