digitalocean / terraform-provider-digitalocean

Terraform DigitalOcean provider
https://registry.terraform.io/providers/digitalocean/digitalocean/latest/docs
Mozilla Public License 2.0
511 stars 279 forks source link

Added support for opensearch configuration on log_destination block #1200

Closed GiovanniColonni closed 3 months ago

GiovanniColonni commented 3 months ago

WIth this PR we would like to add support for OpenShift using the log_destination block. based on the spec of digital ocean we should have something like this:

log_destination: 
  -name: app-staging-opensearch
  open_search:
   basic_auth:
          user: username
   cluster_name: cluster_name
   ndex_name: logs

In the specification created setting the forward from digital ocean from the UI there is no field for password in the basic_auth and im not sure if i have to include it or not

danaelhe commented 3 months ago

1175

GiovanniColonni commented 3 months ago

I see the PR for the documentation but the block for defining the destination is still not available to use in DO with terraform

danaelhe commented 3 months ago

I see the PR for the documentation but the block for defining the destination is still not available to use in DO with terraform

Yes, you're right! Usually we include documentation in the same PR as the implemmentation. Could you add that in this PR if possible? Thank you SO much for your contribution!

GiovanniColonni commented 3 months ago

I only see this file but it's already merged so maybe I don't understand the request

danaelhe commented 3 months ago

I only see this file but it's already merged so maybe I don't understand the request

Oh apologies- you're good then. The documentation you have in this PR already will suffice.