digitalocean / terraform-provider-digitalocean

Terraform DigitalOcean provider
https://registry.terraform.io/providers/digitalocean/digitalocean/latest/docs
Mozilla Public License 2.0
503 stars 270 forks source link

Size of database_connection_pool cannot be edited without recreate #662

Open sundowndev opened 3 years ago

sundowndev commented 3 years ago

Bug Report

Describe the bug

Modifying size of connection pool make Terraform to recreate the connection pool. So I have to edit that field on webui then edit in my HCL file for now.

Is that normal ? What will happen for alive connections when the pool will be recreated ?

Affected Resource(s)

Expected Behavior

Terraform to edit the existing resource.

Actual Behavior

Terraform recreates the connection pool.

Steps to Reproduce

  1. Create a database connection pool, apply
    resource "digitalocean_database_connection_pool" "pool-01" {
    cluster_id = digitalocean_database_cluster.postgres-example.id
    name       = "pool-01"
    mode       = "transaction"
    size       = 8
    db_name    = "defaultdb"
    user       = "doadmin"
    }
  2. Increase the size of the pool, run plan
    -  size       = 8
    + size       = 10
    db_name    = "defaultdb"
    user       = "doadmin"
    }

Let me know if you need further information

mustafayildirim commented 3 years ago

I don't think Edit Connection Pool Api exists.

You can only add a new connection pool https://docs.digitalocean.com/reference/api/api-reference/#operation/add_connection_pool

andrewsomething commented 2 years ago

Just wanted to follow up here to mention that this feedback has been passed on to the Database as a Service team at DigitalOcean.