search

digitalservicebund / useid-app-ios

iOS client for BundesIdent
MIT License
5 stars 1 forks source link

Use "Viewer" for CFBundleTypeRole #114

Closed misery closed 2 years ago

misery commented 2 years ago

Changeset e3d89e2a introduced CFBundleTypeRole and CFBundleURLSchemes with "bundid". But changeset 85426020 switched it to "eid". Since "eid" is defined by the BSI (TR) this should be "Viewer" instead of "Editor".

https://developer.apple.com/documentation/xcode/defining-a-custom-url-scheme-for-your-app

Choose a role for your app: either an editor role for URL schemes you define, or a viewer role for schemes your app adopts but doesn’t define.

ChaosCoder commented 2 years ago

Thank you for the PR, you are right, we missed setting the correct CFBundleTypeRole.

As we require signed commits (last sentence in https://github.com/digitalservicebund/useid-app-ios/blob/main/doc/adr/0003-branching-strategy.md#decision) and your commit signature is unverified, please resign your commit. https://docs.github.com/en/authentication/troubleshooting-commit-signature-verification/using-a-verified-email-address-in-your-gpg-key I will merge this PR as soon as this is done.

misery commented 2 years ago

Done. :-)