search

dilagurung / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Remove depencency on //ppapi in BUILD.gn #374

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This blocks WebRTC from rolling our Chromium revision in WebRTC DEPS.
Libyuv shouldn't depend on such a large part of Chromium, since it'll make it 
hard to integrate it into other projects.

Original issue reported on code.google.com by kjellan...@google.com on 20 Oct 2014 at 6:36

GoogleCodeExporter commented 9 years ago 
For perforce nacl builds (currently used to ship), we're on m31.  So the 
version check disables key features.

Affects files/lines

BUILD.gn
    "//ppapi:ppapi_macros",  # Allow include of pp_macros.h.

row.h
#if defined(__native_client__)
#include "ppapi/c/pp_macros.h"  // For PPAPI_RELEASE
#endif

// Enable for NaCL pepper 33 for bundle and AVX2 support.
#if defined(__native_client__) && PPAPI_RELEASE >= 33
#define NEW_BINUTILS
#endif
#if defined(__native_client__) && defined(__arm__) && PPAPI_RELEASE < 37
#define LIBYUV_DISABLE_NEON
#endif

// TODO(nfullagar): When pepper_33 toolchain is distributed, default to
// NEW_BINUTILS and remove all BUNDLEALIGN occurances.
#if defined(NEW_BINUTILS)
#define BUNDLELOCK ".bundle_lock\n"
#define BUNDLEUNLOCK ".bundle_unlock\n"
#define BUNDLEALIGN "\n"
#else
#define BUNDLELOCK "\n"
#define BUNDLEUNLOCK "\n"
#define BUNDLEALIGN ".p2align 5\n"
#endif

Original comment by fbarch...@google.com on 20 Oct 2014 at 11:08

GoogleCodeExporter commented 9 years ago 
fixed in r1130

Original comment by fbarch...@google.com on 21 Oct 2014 at 1:18