dillontkh / pe

0 stars 0 forks source link

No recourse for irreversible `clear` command #2

Open dillontkh opened 2 months ago

dillontkh commented 2 months ago

As a user who is accustomed to using the CLI, the clear command is something I use often to clear the message logs.

In the application, the clear command irreversibly clears all contacts with no option to undo.

This could pose a serious issue to advanced CLI users who habitually use the clear command.

soc-se-bot commented 2 months ago

Team's Response

Hi, thanks for pointing this out, however we believe that this is not a big issue as the clear command is very distinguishable from all our other commands and it is highly unlikely that the user will ever accidentally run it.

An 'undo' command would be helpful, however, we believe that it is of a much lower priority than the other features we have implemented.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I believe I explained in my original bug report why a user experienced with the CLI (which the target user is) would use the clear out of habit, as it is an extremely common and frequently used command.

Furthermore, a simple way to counteract this would be to simply require a confirmation flag. e.g. clear /confirm, which would not take much effort to implement.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** To determine the severity of this issue, I utilized a risk assessment matrix similar to the one below. (The one below just an example) ![RP_Cover_What-is-a-risk-assessment-matrix-1-1200x675.jpg](https://raw.githubusercontent.com/dillontkh/pe/main/files/d1d6f088-39b3-4ee5-8d11-79206dc8f2fc.jpg) While the **_likelihood_** of the user accidentally typing the `clear` command might be low, the **_impact_** of doing so is extremely high. (For a patient management app, what's worse than the unsalvageable loss of all patient data?). Thus, I believe that a `Medium` severity is fair for this issue.